version: validate format of the git tag #12533
Conversation
bkueng
force-pushed
the
validate_git_tag
branch
3 times, most recently
from
d62980e to
6f98f8a
Compare
There was a problem hiding this comment.
I'm confused why later we use the variable git_version which is directly extracted from another git command and does not go through the check that you added.
Shouldn't these two things be based on the same git command? That way what you extracted and checked is also used (and therefore correct)?
| args = parser.parse_args() | ||
| filename = args.filename | ||
| verbose = args.verbose | ||
| validate = args.validate |
There was a problem hiding this comment.
This is nicer with argparse. Overall it would be nice to split this script up into functions but that could follow in a future PR.
This fails the build if a wrong version tag is used. A wrong tag leads to wrong reporting in QGC, and incorrect error messages about minimum required PX4 version. It also leads to wrong statistics on Flight Review.
|
This fails the build if a wrong version tag is used.
A wrong tag leads to wrong reporting in QGC, and incorrect error messages about minimum required PX4 version.
It also leads to wrong statistics on Flight Review.