Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sensors: create vehicle_accelerometer module #12597

Merged
merged 1 commit into from
Aug 7, 2019

Conversation

dagar
Copy link
Member

@dagar dagar commented Aug 1, 2019

Builds on #12596.

This adds a high rate, low latency, vehicle body frame, filtered, bias corrected acceleration for use in various controllers throughout the code base. The structure is analogous to vehicle_angular_velocity.

@dagar dagar force-pushed the pr-vehicle_accelerometer branch from 48b64f3 to 8c8c628 Compare August 6, 2019 17:12
@dagar dagar requested a review from jlecoeur August 6, 2019 17:13
@dagar dagar changed the title [WIP] sensors: create vehicle_accelerometer module sensors: create vehicle_accelerometer module Aug 6, 2019
@dagar dagar marked this pull request as ready for review August 6, 2019 17:13
@dagar dagar force-pushed the pr-vehicle_accelerometer branch from 8c8c628 to 0084f6f Compare August 6, 2019 18:32
@@ -122,6 +122,7 @@ set(msg_files
uavcan_parameter_value.msg
ulog_stream.msg
ulog_stream_ack.msg
vehicle_accelerometer.msg
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bike shedding: the name is not coherent with other similar topics (vehicle_local_position, vehicle_attitude, vehicle_angular_velocity).

vehicle_acceleration is more coherent.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Option A:
module VehicleAcceleration -> topic vehicle_acceleration
module VehicleAngularVelocity -> topic vehicle_angular_velocity

Option B:
module VehicleAccelerometer -> topic vehicle_acceleration
module VehicleGyroscope -> topic vehicle_angular_velocity

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, but I didn't want to cause confusion with vehicle acceleration not including gravity.

msg/vehicle_accelerometer.msg Outdated Show resolved Hide resolved
msg/sensor_bias.msg Show resolved Hide resolved
src/modules/fw_pos_control_l1/FixedwingPositionControl.cpp Outdated Show resolved Hide resolved
src/modules/land_detector/MulticopterLandDetector.cpp Outdated Show resolved Hide resolved
@dagar dagar force-pushed the pr-vehicle_accelerometer branch from 6181395 to 1285cf9 Compare August 7, 2019 01:19
@dagar
Copy link
Member Author

dagar commented Aug 7, 2019

I've applied most of your suggestions, including renaming to vehicle_acceleration with a mention of gravity in the comment. The goal of the original naming (vehicle_accelerometer) was to try and prevent potential confusion. Thoughts?

@dagar dagar force-pushed the pr-vehicle_accelerometer branch from 1285cf9 to d17488e Compare August 7, 2019 02:08
@jlecoeur
Copy link
Contributor

jlecoeur commented Aug 7, 2019

I agree that it can get confusing. There are three different things people may want: measured acceleration (body frame, including gravity), body linear acceleration (body frame, excluding gravity) and linear acceleration (ground frame, excluding gravity, aka derivative of NED velocity). Finding unambiguous names is difficult here. At least the comment in the message definition is clear.

@dagar dagar merged commit a917f22 into PX4:master Aug 7, 2019
@dagar dagar deleted the pr-vehicle_accelerometer branch August 7, 2019 09:05
bozkurthan pushed a commit to bozkurthan/Firmware that referenced this pull request Sep 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants