-
Notifications
You must be signed in to change notification settings - Fork 13.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sensors: create vehicle_accelerometer module #12597
Conversation
48b64f3
to
8c8c628
Compare
8c8c628
to
0084f6f
Compare
msg/CMakeLists.txt
Outdated
@@ -122,6 +122,7 @@ set(msg_files | |||
uavcan_parameter_value.msg | |||
ulog_stream.msg | |||
ulog_stream_ack.msg | |||
vehicle_accelerometer.msg |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bike shedding: the name is not coherent with other similar topics (vehicle_local_position, vehicle_attitude, vehicle_angular_velocity).
vehicle_acceleration
is more coherent.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Option A:
module VehicleAcceleration
-> topic vehicle_acceleration
module VehicleAngularVelocity
-> topic vehicle_angular_velocity
Option B:
module VehicleAccelerometer
-> topic vehicle_acceleration
module VehicleGyroscope
-> topic vehicle_angular_velocity
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree, but I didn't want to cause confusion with vehicle acceleration not including gravity.
src/modules/sensors/vehicle_accelerometer/VehicleAccelerometer.cpp
Outdated
Show resolved
Hide resolved
6181395
to
1285cf9
Compare
I've applied most of your suggestions, including renaming to |
1285cf9
to
d17488e
Compare
I agree that it can get confusing. There are three different things people may want: measured acceleration (body frame, including gravity), body linear acceleration (body frame, excluding gravity) and linear acceleration (ground frame, excluding gravity, aka derivative of NED velocity). Finding unambiguous names is difficult here. At least the comment in the message definition is clear. |
Builds on #12596.
This adds a high rate, low latency, vehicle body frame, filtered, bias corrected acceleration for use in various controllers throughout the code base. The structure is analogous to vehicle_angular_velocity.