Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logger move non-logged subscriptions to uORB::Subscription #12639

Merged
merged 2 commits into from
Aug 6, 2019

Conversation

dagar
Copy link
Member

@dagar dagar commented Aug 6, 2019

Smaller pieces broken out of #12123.

@dagar dagar requested a review from bkueng August 6, 2019 06:09
@dagar dagar changed the title Pr logger u orb subscription logger move non-logged subscriptions to uORB::Subscription Aug 6, 2019
@dagar dagar force-pushed the pr-logger-uORB_Subscription branch from de696f9 to 94e27ec Compare August 6, 2019 06:09
Copy link
Member

@bkueng bkueng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good up to the 2 points I remarked.

src/modules/logger/log_writer_mavlink.cpp Outdated Show resolved Hide resolved
src/modules/logger/logger.cpp Show resolved Hide resolved
@dagar dagar force-pushed the pr-logger-uORB_Subscription branch from 94e27ec to 8a0ebf0 Compare August 6, 2019 14:34
@dagar dagar requested a review from bkueng August 6, 2019 14:35
@dagar dagar merged commit 6f2d1d5 into PX4:master Aug 6, 2019
@dagar dagar deleted the pr-logger-uORB_Subscription branch August 6, 2019 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants