-
Notifications
You must be signed in to change notification settings - Fork 13.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ubuntu.py: update to dual install to Python2 #12788
Conversation
Gazebo fails with this build log after setting up env with this file. EDITED: I updated the gazebo section to include everything in docker. The minimum to start gazebo is much smaller (protobuf-compiler libeigen3-dev libopencv-dev gazebo9 libgazebo9-dev) but I am assuming you need the rest for video simulation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm opposed to this change. I would rather have everything properly changed to Python3.
I have been building PX4 for years on systems with Python3 as the default, so I want to understand why that would not work.
@julianoes So would I. But are you happy to urgently commit the time to working out how to do it? At the moment there is no working mechanism for automated environment setup on ubuntu. Getting this out there and allowing easy setup is more important than "general principle". |
Note, getting some warnings:
|
@hamishwillee alright here #12809. |
@julianoes You're my hero :-). I'll close this once that goes in and I can retest. |
@hamishwillee maybe will need this as an intermediate step. Python 3 everywhere isn't trivial I had to find out. |
@julianoes OK, can you or @dagar approve the merge then? |
@dagar Thanks. Is this in CI yet too? If not, any clues/pointers to similar things that I might copy to get it in. Basically I want to make sure that this can be used to set up an env that builds jmavsim, gazebo and nuttx. Ideally also tests that the SIMs run successfully. |
The current build depends on some Python 2; this just adds all python 2 depdendencies to the "user build script".
Note is WIP. Jmavsim works, but Gazebo (9) isn't starting on ubuntu 16.04. More testing required.