Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gitignore remove core #12812

Merged
merged 1 commit into from
Aug 27, 2019
Merged

gitignore remove core #12812

merged 1 commit into from
Aug 27, 2019

Conversation

dagar
Copy link
Member

@dagar dagar commented Aug 27, 2019

This is too generic and causing files to be ignored in #12575.

bkueng
bkueng approved these changes Aug 27, 2019
View reviewed changes
Copy link
Member

@bkueng bkueng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If only top-level entries should be matched, we need to prefix with /.

@dagar dagar merged commit a20b508 into master Aug 27, 2019
@dagar dagar deleted the pr-gitignore branch August 27, 2019 13:00
@weekly-digest weekly-digest bot mentioned this pull request Sep 1, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bkueng bkueng bkueng approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dagar @bkueng