px4_work_queue: command line status output and shutdown empty queues #12853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dagar
force-pushed
the
pr-wq_status
branch
4 times, most recently
from
81737ad to
32f2d22
Compare
dagar
changed the title
|
Adding this to the ulog additional data would be nice, but not immediately required. I won't be offended if someone would like to improve on my printf tree here. |
|
Removing the interval perf counters in each WorkItem driver/module saved a bit more than 1% cpu on an px4_fmu-v4 (generic quadcopter). |
|
Limiting to ascii characters for better terminal portability.
|
julianoes
reviewed
Sep 3, 2019
platforms/common/include/px4_platform_common/px4_work_queue/ScheduledWorkItem.hpp
Outdated
Show resolved
Hide resolved
platforms/common/include/px4_platform_common/px4_work_queue/WorkItem.hpp
Outdated
Show resolved
Hide resolved
* remove unnecessary friend
|
Currently fitting in fmu-v2 flash again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the PX4 work queue to keep a list of attached WorkItems. This list is used to iterate all items to get an overall status of the work queues (tree view) and to stop any empty queues.
I've added a new
work_queuesystemcmd to get the status and potentially manually start/stop if we need it later (likely needs work).