-
Notifications
You must be signed in to change notification settings - Fork 13.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sensors: split out battery_status to new module #13073
Conversation
f84e62c
to
7ea13bb
Compare
cd8e592
to
59f7d3c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested successfully. I can't actually get off the ground cuz ESC issues, but everything else works as expected.
6d152d3
to
eda74fa
Compare
Is it necessary to move the whole adc function out of DriverFramework? Currently differential pressure sensor and battery which rely on adc are all based on df. |
Yes, but that part actually shouldn't be too difficult. Short term the DriverFramework usage can be replaced with CDev (for block device access) and the new PX4 work queue (for period scheduling). In the ADC case I'd like to consider merging the frontends and only having to provide a few minor calls for ADC access. Then most platforms could share this common ADC frontend. https://github.com/PX4/Firmware/blob/master/src/drivers/adc/adc.cpp |
eda74fa
to
1ca0031
Compare
@SalimTerryLi just to be clear on my previous comment, it's necessary medium term to get everything moved out of DriverFramework for several other important reasons, but short term it's not necessary for the sake of analog battery and airspeed. |
@dagar Got it. I would like to have a try :) |
@dagar are you still planning on doing that? If so, when? This is a bit unfortunate because @ItsTimmy had his PR ready to be merged a while ago and we were waiting on the release to go out to then merge these things. We should coordinate these things better otherwise it can be frustrating. |
Quick PR to split out the analog battery handling from the sensors module.