Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reactivate OA/SL in CI #13113

Merged
merged 2 commits into from
Oct 14, 2019
Merged

Reactivate OA/SL in CI #13113

merged 2 commits into from
Oct 14, 2019

Conversation

mrivi
Copy link
Contributor

@mrivi mrivi commented Oct 7, 2019

No description provided.

@TSC21
Copy link
Member

TSC21 commented Oct 7, 2019

@TSC21
Copy link
Member

TSC21 commented Oct 7, 2019

@mrivi
Copy link
Contributor Author

mrivi commented Oct 7, 2019

yes, I know the pyYaml problem. I did the fix on mavros

@TSC21
Copy link
Member

TSC21 commented Oct 7, 2019

yes, I know the pyYaml problem. I did the fix on mavros

Right :D

@TSC21
Copy link
Member

TSC21 commented Oct 9, 2019

@TSC21
Copy link
Member

TSC21 commented Oct 9, 2019

So, all good with safe landing. Now, just need to check the issue with the lidar model so to fix the avoidance test.

@mrivi
Copy link
Contributor Author

mrivi commented Oct 10, 2019

I think the only piece missing is a new avoidance release. We need it because:

  • in the Firmware CI we were using the mavros/launch/px4_config.yaml that with the container update and consequent mavros update yields two separate trees
  • the px4_config.yaml in avoidance release 0.3.0 is not updated to use directly radians but the tag !degree which doesn't load anymore due to the pyYaml update

FYI @jkflying

@TSC21
Copy link
Member

TSC21 commented Oct 10, 2019

@mrivi what about cherry-picking the required changes from master to 0.3.0 release for now?

@TSC21 TSC21 marked this pull request as ready for review October 10, 2019 15:22
@TSC21 TSC21 requested a review from jkflying October 10, 2019 15:23
@TSC21 TSC21 changed the title Debug OA CI failures Reactivate OA/SL in CI Oct 10, 2019
@mrivi
Copy link
Contributor Author

mrivi commented Oct 14, 2019

@TSC21 this is good to merge

@dagar dagar merged commit 123f769 into master Oct 14, 2019
@dagar dagar deleted the fix_oa_ci branch October 14, 2019 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants