VFR_HUD: add attitude for user display #13114
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems fine to me as long as no one is opposed to the mavlink change. |
dagar
reviewed
Oct 7, 2019
|
|
||
| // Attitude | ||
| const matrix::Quatf att = matrix::Quatf(attitude.q) * _rotation; | ||
| msg.q1 = att(0); |
There was a problem hiding this comment.
I suppose this is a question for mavlink/mavlink#1247, but why isn't the quaternion an array?
There was a problem hiding this comment.
I used the same format as in ATTITUDE_QUATERNION.
Both should be array in my opinion, or at least 0 indexed...
julianoes
reviewed
Oct 8, 2019
| @@ -1635,7 +1635,7 @@ Mavlink::configure_streams_to_default(const char *configure_single_stream) | |||
| configure_stream_local("SERVO_OUTPUT_RAW_0", 1.0f); | |||
| configure_stream_local("SYS_STATUS", 1.0f); | |||
| configure_stream_local("UTM_GLOBAL_POSITION", 0.5f); | |||
| configure_stream_local("VFR_HUD", 4.0f); | |||
| configure_stream_local("VFR_HUD", 15.0f); | |||
There was a problem hiding this comment.
@dagar remember our conversation? So which one is really used?
There was a problem hiding this comment.
In QGC, once ATTITUDE_QUATERNION is received, ATTITUDE is ignored.
|
replaced by #13249 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
( Requires MAVLink PR mavlink/mavlink#1247 )
This PR handles the extension of VFR_HUD with attitude fields meant for user display.
See MAVLink PR for details.
fixes #5291 #10405