Commander: bugfix: get all available messages on the subsystem_info t… #13121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julianoes
reviewed
Oct 8, 2019
src/modules/commander/Commander.cpp
Outdated
| @@ -1737,7 +1737,7 @@ Commander::run() | |||
|
|
|||
| /* update subsystem info which arrives from outside of commander*/ | |||
| do { | |||
| if (subsys_sub.updated()) { | |||
| if ( (updated=subsys_sub.updated()) ) { | |||
There was a problem hiding this comment.
Wow, this updated bool is defined 500 lines above. It looks like it's not used anywhere else. Could you move it down to here where it's used?
There was a problem hiding this comment.
Actually, can't you just simplify it like this?
/* update subsystem info which arrives from outside of commander*/
while (subsys_sub.updated()) {
subsystem_info_s info{};
subsys_sub.copy(&info);
set_health_flags(info.subsystem_type, info.present, info.enabled, info.ok, status);
status_changed = true;
}
There was a problem hiding this comment.
also tested, it gets at most 5 messages in 1 commander loop, which is limited by the messages orb queue size
dusan19
force-pushed
the
commander_subsystem_get_bugfix
branch
from
3e97bb4 to
855a884
Compare
bkueng
reviewed
Oct 9, 2019
dusan19
force-pushed
the
commander_subsystem_get_bugfix
branch
from
855a884 to
2c84eff
Compare
bkueng
reviewed
Oct 10, 2019
dusan19
force-pushed
the
commander_subsystem_get_bugfix
branch
from
2c84eff to
1a2d756
Compare
bkueng
approved these changes
Oct 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…opic
Bugfix when getting all available messages on the subsystem_info topic in commander