Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added fields to the MavlinkReciever::handle_message_distance_sensor() method #13131

Merged
merged 2 commits into from
Oct 8, 2019

Conversation

mcsauder
Copy link
Contributor

@mcsauder mcsauder commented Oct 8, 2019

Describe problem solved by the proposed pull request
This PR addresses Issue #11133. The PR adds missing fields and a TODO to indicate why the missing field cannot be populated due to the mavlink message definition lacking that field.

At some point we will need to get the mavlink definition updated to match as well, but at least for now there will be a placeholder reminder.

Additional context
See Issue #11133
Please let me know if you have any concerns on this PR. Thanks!

-Mark

@TSC21
Copy link
Member

TSC21 commented Oct 8, 2019

@mcsauder the only field that is missing is the signal quality: https://mavlink.io/en/messages/common.html#DISTANCE_SENSOR. For the signal quality, one can always set it to max so to be accepted.

@mcsauder mcsauder force-pushed the mavlink_receiver_distance_sensor branch from 646c9c3 to abe44a4 Compare October 8, 2019 19:40
@mcsauder mcsauder changed the title Added (commented) fields to the MavlinkReciever::handle_message_distance_sensor() method Added fields to the MavlinkReciever::handle_message_distance_sensor() method Oct 8, 2019
@mcsauder
Copy link
Contributor Author

mcsauder commented Oct 8, 2019

@mcsauder the only field that is missing is https://mavlink.io/en/messages/common.html#DISTANCE_SENSOR. For the signal quality, one can always set it to max so to be accepted.

Thanks @TSC21 ! I've updated the commit to fix things up. I was blind! Thanks again!

@TSC21
Copy link
Member

TSC21 commented Oct 8, 2019

@mcsauder the only field that is missing is https://mavlink.io/en/messages/common.html#DISTANCE_SENSOR. For the signal quality, one can always set it to max so to be accepted.

Thanks @TSC21 ! I've updated the commit to fix things up. I was blind! Thanks again!

No problem.

@mcsauder
Copy link
Contributor Author

mcsauder commented Oct 8, 2019

Hi @TSC21 , I added a default value for the signal quality that mirrors the values being set in distance sensor drivers lacking that value as well as the default PX4Rangefinder value. Thanks for your feedback!

@TSC21 TSC21 merged commit 6066300 into PX4:master Oct 8, 2019
@mcsauder mcsauder deleted the mavlink_receiver_distance_sensor branch October 8, 2019 20:25
@mcsauder
Copy link
Contributor Author

mcsauder commented Oct 8, 2019

Thanks @TSC21 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants