Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mavlink: fix boot complete without lockstep #13137

Merged
merged 1 commit into from
Oct 10, 2019

Conversation

julianoes
Copy link
Contributor

Describe problem solved by the proposed pull request

Without lockstep the actual monotonic clock of the host computer is used. Therefore, this time is likely much more than 20 seconds and the check if the boot complete happened in time will fail immediately.

Therefore, it probably makes more sense to count the time from the first mavlink creation.

Test data / coverage

Tested in SITL with and without lockstep.

Without lockstep the actual monotonic clock of the host computer is
used. Therefore, this time is likely much more than 20 seconds and the
check if the boot complete happened in time will fail immediately.

Therefore, it probably makes more sense to count the time from the first
mavlink creation.
@julianoes julianoes requested review from dagar and bkueng October 9, 2019 09:05
@LorenzMeier LorenzMeier merged commit 307dc3e into master Oct 10, 2019
@julianoes julianoes deleted the pr-fix-mavlink-boot-wo-lockstep branch October 10, 2019 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants