Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PULL_REQUEST_TEMPLATE: change order of titles #13174

Merged
merged 1 commit into from
Oct 14, 2019
Merged

Conversation

MaEtUgR
Copy link
Member

@MaEtUgR MaEtUgR commented Oct 13, 2019

Describe problem solved by the proposed pull request
I like the pull request template a lot but every time I'm changing the order of the titles in the same way because first I want to describe what it contains and then how it was tested.

Describe your preferred solution
I changed the order of the titles to be IMHO more intuitive.

Additional context
Last such reorder: bff9368#diff-7240be7a02d8789cae2c0970f0260dfe which I accidentally commited directly because of a GitHub web UI bug.

@MaEtUgR MaEtUgR requested a review from LorenzMeier October 13, 2019 15:49
@MaEtUgR MaEtUgR self-assigned this Oct 13, 2019
Copy link
Contributor

@julianoes julianoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's better!

@julianoes julianoes merged commit 093d3b7 into master Oct 14, 2019
@julianoes julianoes deleted the MaEtUgR-patch-1 branch October 14, 2019 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants