Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mavlink: only send ATTITUDE/ATTITUDE_QUATERNION msgs on vehicle_attitude update #13184

Merged
merged 2 commits into from
Oct 14, 2019
Merged

mavlink: only send ATTITUDE/ATTITUDE_QUATERNION msgs on vehicle_attitude update #13184

merged 2 commits into from
Oct 14, 2019

Conversation

dagar
Copy link
Member

@dagar dagar commented Oct 14, 2019

@dagar dagar added the bug label Oct 14, 2019
@dagar dagar requested a review from mrivi October 14, 2019 14:18
@dagar
Copy link
Member Author

dagar commented Oct 14, 2019

It might be worth doing a quick pass over the messages required by PX4/avoidance to ensure the correct data is being sent only in valid conditions.

@dagar dagar mentioned this pull request Oct 14, 2019
Closed
mrivi
mrivi approved these changes Oct 14, 2019
View reviewed changes
Copy link
Contributor

@mrivi mrivi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this. I wasn't if it was a critical choice to have the updated message with the OR condition on the update.

@dagar dagar merged commit c514756 into master Oct 14, 2019
@dagar dagar deleted the pr-mavlink_attitude_quat branch October 14, 2019 19:47
@mrivi mrivi mentioned this pull request Oct 15, 2019
Closed
@weekly-digest weekly-digest bot mentioned this pull request Oct 20, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrivi mrivi mrivi approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Attitude Quaternion Stream with invalid quaternion
2 participants
@dagar @mrivi