Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ModalAI FC1 target #13222

Merged
merged 3 commits into from
Oct 19, 2019
Merged

Add support for ModalAI FC1 target #13222

merged 3 commits into from
Oct 19, 2019

Conversation

modaltb
Copy link
Contributor

@modaltb modaltb commented Oct 17, 2019

Describe problem solved by this pull request
This PR is to add support for the ModalAI Flight Core 1 board. This has some commonality with the v5x hardware but is a derivative with designs to mate with the VOXL companion computer. The fmu_v5x board support was used as the starting point.

The bootloader update for this board has a PR here:
PX4/PX4-Bootloader#155

Describe your solution
NA

Describe possible alternatives
NA

Test data / coverage
Flight testing has been ongoing for the last months with positive results. Please push back and let me know if more is needed! :)

Additional context
I can ship hardware to anyone if needed for testing, just let me know!

@dagar
Copy link
Member

dagar commented Oct 17, 2019

Can you add the build to Jenkins? https://github.com/PX4/Firmware/blob/cefa7ec5dc55ea03c0518670c3622043a535676c/.ci/Jenkinsfile-compile#L38

@modaltb
Copy link
Contributor Author

modaltb commented Oct 17, 2019

Not sure if the Jenkins job picked up the change with the added target, it's not appearing in the "Compile All Boards" step. I can re-submit a PR if needed to 'flush' the change if that's needed.

@hamishwillee
Copy link
Contributor

When you're in production you might want to document the board. Typically that is done in 2 places:

@modaltb
Copy link
Contributor Author

modaltb commented Oct 17, 2019

@hamishwillee thanks for the heads up, I created a task on our end to get this in place before production release.

@dagar dagar self-requested a review October 18, 2019 17:53
- also removed the unused IMU drivers from default.cmake
@dagar dagar merged commit 3bbf1cc into PX4:master Oct 19, 2019
@modaltb modaltb deleted the pr-modalai-fc1 branch October 22, 2019 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants