Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't implement print_message for fmu-v2 #13226

Merged
merged 1 commit into from
Oct 18, 2019
Merged

Don't implement print_message for fmu-v2 #13226

merged 1 commit into from
Oct 18, 2019

Conversation

julianoes
Copy link
Contributor

@julianoes julianoes commented Oct 18, 2019 •
edited
Loading

This saves about 3.4k of flash for fmu-v2.

     VM SIZE    
 -------------- 
  [ = ]       0    [Unmapped]
  [ = ]       0    [section .debug_abbrev]
  [ = ]       0    [section .debug_frame]
  [ = ]       0    [section .debug_info]
  [ = ]       0    [section .debug_line]
  [ = ]       0    [section .debug_loc]
  [ = ]       0    [section .debug_ranges]
  [ = ]       0    [section .debug_str]
  [ = ]       0    [section .symtab]
  [DEL]     -16    CSWTCH.5
  [DEL]     -64    CSWTCH.4
  -1.0%    -900    [section .text]
 -96.7% -2.44Ki    print_message()
  -0.3% -3.40Ki    TOTAL

@julianoes
msg: don't implement print_message for fmu-v2
27ff716 
This saves about 3.4k of flash for fmu-v2.
@julianoes julianoes requested a review from dagar October 18, 2019 09:25
@julianoes julianoes changed the title msg: don't implement print_message for fmu-v2 Don't implement print_message for fmu-v2 Oct 18, 2019
@julianoes julianoes requested a review from bkueng October 18, 2019 09:26
@LorenzMeier
Copy link
Member

Cool!

@julianoes
Copy link
Contributor Author

@LorenzMeier I need this to get the failsafe fixes into the release 😕.

@LorenzMeier LorenzMeier merged commit d3da4a9 into master Oct 18, 2019
@LorenzMeier
Copy link
Member

Done!

@LorenzMeier LorenzMeier deleted the pr-print-message-flash branch October 18, 2019 09:54
@weekly-digest weekly-digest bot mentioned this pull request Oct 20, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LorenzMeier LorenzMeier LorenzMeier approved these changes

@dagar dagar Awaiting requested review from dagar

@bkueng bkueng Awaiting requested review from bkueng

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@julianoes @LorenzMeier