Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mpu6000: remove factory test #13227

Merged
merged 1 commit into from
Oct 18, 2019
Merged

mpu6000: remove factory test #13227

merged 1 commit into from
Oct 18, 2019

Conversation

julianoes
Copy link
Contributor

My assumption is that this is not used or needed and we can remove it to save some flash space.

     VM SIZE    
 -------------- 
  [ = ]       0    [Unmapped]
  [ = ]       0    [section .debug_abbrev]
  [ = ]       0    [section .debug_aranges]
  [ = ]       0    [section .debug_frame]
  [ = ]       0    [section .debug_info]
  [ = ]       0    [section .debug_line]
  [ = ]       0    [section .debug_loc]
  [ = ]       0    [section .debug_ranges]
  [ = ]       0    [section .debug_str]
  -6.0%     -20    mpu6000_main
  [DEL]     -44    mpu6000::factorytest()
  -0.1%     -64    [section .text]
  [DEL] -1.20Ki    MPU6000::factory_self_test()
  -0.1% -1.33Ki    TOTAL

@julianoes julianoes requested a review from dagar October 18, 2019 09:35
@LorenzMeier
Copy link
Member

I wouldn't want to strip the code (we do need self-tests and will add more of them) but I think this could be guarded behind the same low-flash flag that we're using in other places.

@julianoes
Copy link
Contributor Author

julianoes commented Oct 18, 2019

@LorenzMeier I agree but we don't yet have such a define, or I can't find it.

Ok, I've added a define. It's not pretty.

@julianoes julianoes force-pushed the pr-remove-mpu6k-factorytest branch from ea29a2a to b4d7a5b Compare October 18, 2019 10:10
@dagar
Copy link
Member

dagar commented Oct 18, 2019

This is fine for now as it was effectively unused. The line I don't want to cross with CONSTRAINED_FLASH is any actual functionality change from a users perspective.

In the new drivers I was planning to add factory self test as part of init, but haven't gotten around to it yet.

@dagar dagar merged commit f9ddbd7 into master Oct 18, 2019
@dagar dagar deleted the pr-remove-mpu6k-factorytest branch October 18, 2019 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants