Corrections on DO_SET_SERVO mission item #4965
Conversation
More visible mixers loading process with output to bootlog.txt adding DO_SET_SERVO mission item check in navigator( before only first mission item are checked)
| } | ||
| /* check only items with valid lat/lon */ | ||
| else if (isPositionCommand(mission_item.nav_cmd)) { | ||
| /* Check non navigation item */ |
There was a problem hiding this comment.
Why is this check now present 2 times?
There was a problem hiding this comment.
Hello Lorenz,
I have sent the pull request from my new github account "px4user".
In your comment we have a check of output first and next the check of desired PWM value.
But generally in module mission_feasibility_checker.cpp we have function checkMissionItemValidity where we check all mission items
Als we have function check_dist_1wp where some body have initially added check of DO_SET_SERVO mission item. From my point of view it can be excluded. But as is not me who have added this i prefered to keep it.
Regards,
Michail.
There was a problem hiding this comment.
I would prefer to have the check at a single location.
|
Thanks for the update! |
|
Hello, Lorenz, |
|
Hello? Lorenz, |
|
Lorenz is currently travelling, he'll be back by the end of the month |
|
Hi, |
|
Hello, Lorenz! |
|
Navigator change looks good, the mixer change is difficult - you can now have conflicting inputs on the payload. I would like to understand the issue you were trying to solve - is the issue that manual pass-through in your case is not a good thing? It seems like we would need a payload controller arbitrating between manual and automatic passthrough mode. |
|
@thedevleon I think you also fixed the pass-through mixer in your PR. I'd like to get that onto master before the release. |
| S: 3 4 10000 10000 0 -10000 10000 | ||
|
|
||
| # AUX5 channel (select servo id 5 in mission item) |
There was a problem hiding this comment.
I need to check if this can conflict with camera triggering.
|
Hi! |
|
Ok, i see - it can confict with trigger module, i never checked with control group this module use.... |
|
Can one of the admins verify this patch? |
|
@fpvaspassion status? |
|
I'm not sure what happened here, but is there still interest in this PR? If so it badly needs a rebase. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
Closing as stale. |
Hello,
I have modified default auxiliary mixer to accept input from actuators group 2
Next i added bootlog.txt as output into rc.interface to have more visible mixers loading process when user try to upload own mixer
Last change - adding DO_SET_SERVO mission item check in navigator( before only first mission item are checked) and correction of limits for id of AUX outputs ( from 0...5 to 1...6)
Changes are tested in flight today for all 6 AUX channels.
Regards,
Michail.