vtol_att_control: handle front transition timeout for all types #9341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dagar This moves front transition timeout logic to base class so that it is available for all vtol types. |
|
That looks much better. What do you think about back transition timeout? Rebase on master to get CI working (#9339). |
dagar
added
Admin: Enhancement (improvement) 💡
Hybrid VTOL 🛩️🚁
RomanBapst
force-pushed
the
pr-front_trans_timeout
branch
from
83f3780 to
352565f
Compare
- moved front transition timout logic to base class so that it's available for all vtol types - cleaned up variable usage Signed-off-by: Roman <bapstroman@gmail.com>
Signed-off-by: Roman <bapstroman@gmail.com>
- copy timestamp_sample through to final actuator_control
Signed-off-by: Roman <bapstroman@gmail.com>
Signed-off-by: Roman <bapstroman@gmail.com>
RomanBapst
force-pushed
the
pr-front_trans_timeout
branch
from
01be330 to
9bbbc9b
Compare
RomanBapst
commented
Apr 26, 2018
| @@ -323,7 +299,7 @@ void Standard::update_mc_state() | |||
|
|
|||
| // Do not engage pusher assist during a failsafe event | |||
| // There could be a problem with the fixed wing drive | |||
| if (_attc->get_vtol_vehicle_status()->vtol_transition_failsafe) { | |||
| if (_attc->get_vtol_vehicle_status().vtol_transition_failsafe) { | |||
There was a problem hiding this comment.
@dagar How about _vtol_vehicle_status.vtol_transition_failsafe ?
Signed-off-by: Roman <bapstroman@gmail.com>
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
Closing as stale. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for all vtol types
Signed-off-by: Roman bapstroman@gmail.com