-
Notifications
You must be signed in to change notification settings - Fork 13.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] cmake toolchains cleanup and fix #9808
Conversation
Once our own hacks are removed from the CMake toolchains things like using clang to compile nuttx will work. |
#set(CMAKE_C_FLAGS ${C_FLAGS}) | ||
#set(CMAKE_CXX_LINKER_FLAGS ${C_FLAGS}) | ||
|
||
set(CMAKE_FIND_ROOT_PATH get_file_component(${CMAKE_C_COMPILER} PATH)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the difference on endianness working would actually be related to this.
#message(STATUS "could not find ${tool}") | ||
endif() | ||
endforeach() | ||
set(CMAKE_FIND_ROOT_PATH get_file_component(${CMAKE_C_COMPILER} PATH)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same thing here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks much tight and cleaned up. Let's wait for CI. I would push it as soon as possible.
It's not done yet (CI won't pass). |
Yeah CI seems to have symlink complaints. |
7b2fc39
to
8cf057f
Compare
@dagar any progress on this? |
Still trying to figure out why does the endianness check results on having the |
No, I think we just need to be more careful with setting cmake variables so that the test compile stages of configure work. |
Closer, but not quite working fully. |
@dagar anything that I can do to bring this further? Though the with the endianness check off, I think it is beneficial, not only to micro-CDR, but system wise, to have a clean Cmake build structure. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Closing as stale. |
This is necessary so that cmake configure time compile tests (eg endianness) work properly.
Needed by #9651.