Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] cmake toolchains cleanup and fix #9808

Closed
wants to merge 1 commit into from
Closed

[WIP] cmake toolchains cleanup and fix #9808

wants to merge 1 commit into from

Conversation

dagar
Copy link
Member

@dagar dagar commented Jun 29, 2018

This is necessary so that cmake configure time compile tests (eg endianness) work properly.

Needed by #9651.

@dagar dagar requested a review from TSC21 June 29, 2018 19:26
@dagar
Copy link
Member Author

dagar commented Jun 29, 2018

Once our own hacks are removed from the CMake toolchains things like using clang to compile nuttx will work.

#set(CMAKE_C_FLAGS ${C_FLAGS})
#set(CMAKE_CXX_LINKER_FLAGS ${C_FLAGS})

set(CMAKE_FIND_ROOT_PATH get_file_component(${CMAKE_C_COMPILER} PATH))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the difference on endianness working would actually be related to this.

#message(STATUS "could not find ${tool}")
endif()
endforeach()
set(CMAKE_FIND_ROOT_PATH get_file_component(${CMAKE_C_COMPILER} PATH))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same thing here.

TSC21
TSC21 previously approved these changes Jun 29, 2018
Copy link
Member

@TSC21 TSC21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks much tight and cleaned up. Let's wait for CI. I would push it as soon as possible.

@dagar
Copy link
Member Author

dagar commented Jun 29, 2018

It's not done yet (CI won't pass).

@TSC21
Copy link
Member

TSC21 commented Jun 29, 2018

Yeah CI seems to have symlink complaints.

@dagar dagar force-pushed the pr-toolchains branch 4 times, most recently from 7b2fc39 to 8cf057f Compare June 30, 2018 14:00
@TSC21
Copy link
Member

TSC21 commented Jul 3, 2018

@dagar any progress on this?

@TSC21
Copy link
Member

TSC21 commented Jul 4, 2018

Still trying to figure out why does the endianness check results on having the CMAKE_SYSTEM_PROCESSOR becoming invalid. @dagar do we probably need to force check the endianness on the system we are cross compiling to before the TestBigEndian Cmake test runs?

@dagar
Copy link
Member Author

dagar commented Jul 6, 2018

No, I think we just need to be more careful with setting cmake variables so that the test compile stages of configure work.

@dagar
Copy link
Member Author

dagar commented Jul 6, 2018

Closer, but not quite working fully.

@TSC21
Copy link
Member

TSC21 commented Jul 19, 2018

@dagar anything that I can do to bring this further? Though the with the endianness check off, I think it is beneficial, not only to micro-CDR, but system wise, to have a clean Cmake build structure.

@stale
Copy link

stale bot commented Jan 20, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale
Copy link

stale bot commented Feb 4, 2019

Closing as stale.

@stale stale bot closed this Feb 4, 2019
@dagar dagar deleted the pr-toolchains branch February 6, 2019 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants