Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to add new airframe for FMU-v5 #12631

Closed
themcfadden opened this issue Aug 5, 2019 · 8 comments
Closed

Unable to add new airframe for FMU-v5 #12631

themcfadden opened this issue Aug 5, 2019 · 8 comments
Labels

Comments

@themcfadden
Copy link

themcfadden commented Aug 5, 2019

Describe the bug
Following the instructions outlined in https://dev.px4.io/master/en/airframes/adding_a_new_frame.html, I am unable to add a new airframe under FMU-v5. Everything builds with no issues, but nothing shows up in QGC and the airframes.xml file in the build directory is not updated.

I am able to successfully do it under the FMU-v4 build.

A couple notes:

  • The 4250_Teal, and others are not showing up in my fmu-v5 build. The airframes are there and listed in CMakeLists.txt, but are not part of the build output.
  • Even commenting out something in airframes/CMakeLists.txt does not change anything.
  • I believe the official FW release has the Teal and other missing airframes.

To Reproduce
Steps to reproduce the behavior:

  1. Update or create a new airframe in Firmware/ROMFS/px4fmu_common/init.d/airframes/ as per instructions pointed to above.
  2. make px4_fmu-v5
  3. Check Firmware/build/px4_fmu-v5_default/airframes.xml and observe no changes.

Expected behavior
Airframe is created as in other targets.

Log Files and Screenshots
N/A

Drone (please complete the following information):
N/A but I'm working on a Teal drone

Additional context

@hamishwillee
Copy link
Contributor

I haven't tried this, but in step 3, shouldn't you be checking the v5 path? Firmware/build/px4_fmu-v5_default/airframes.xml

@themcfadden
Copy link
Author

themcfadden commented Aug 5, 2019

I haven't tried this, but in step 3, shouldn't you be checking the v5 path? Firmware/build/px4_fmu-v5_default/airframes.xml

Yes, correct. px4_fmu-v4_default is a cut and paste error.
I updated the original post with px4_fmu-v5_default in the path.

@AlexandreBorowczyk
Copy link

Are you sure the ID you attributed to the new config is unused?

@julianoes
Copy link
Contributor

@RicardoM17
Copy link
Contributor

Check what @julianoes just said. I literally just copied the 4250_teal airframe file into a 4251_teal, deleted that line and it's building on v5.
image

@themcfadden
Copy link
Author

Yep, that's it. Thanks for the quick response!

Just curious, how is the airframe.xml file generated? Is there a script I can review?

@mhkabir
Copy link
Member

mhkabir commented Aug 6, 2019

https://github.com/PX4/Firmware/tree/master/Tools/px4airframes

Closing as resolved.

@mhkabir mhkabir closed this as completed Aug 6, 2019
@RicardoM17
Copy link
Contributor

@themcfadden I believe this is what you are looking for?

https://github.com/PX4/Firmware/blob/master/Tools/px_process_airframes.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants