Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

【Vtol】The left and right ailerons have a large output when they are stationary on the ground. #13167

Closed
xdwgood opened this issue Oct 12, 2019 · 7 comments · Fixed by #13198

Comments

@xdwgood
Copy link
Contributor

xdwgood commented Oct 12, 2019

Use branch: master 803a719

1.Place a tailsitter vtol drone vertically on a level surface, qgc shows the angle of yaw is 90
2.Not arm, but drone left and right ailerons have large output

analysis:
I think it's because the yaw_sp angle is 0 when not arm, but the customer is randomly placed on the drone, so the actual yaw may not be 0, which causes the controller to output to the left and right ailerons.

Screenshot from 2019-10-12 13-42-20

@xdwgood
Copy link
Contributor Author

xdwgood commented Oct 12, 2019

I rotate the drone until the yaw angle is 0 and the left and right ailerons will return to the middle position.

@LorenzMeier
Copy link
Member

Could you send a pull request for that?

@xdwgood
Copy link
Contributor Author

xdwgood commented Oct 14, 2019

@dagar I have verified that this reset caused the problem I described.

				// reinitialize the setpoint while not armed to make sure no value from the last mode or flight is still kept
				if (!_v_control_mode.flag_armed) {
					Quatf().copyTo(_mc_virtual_att_sp.q_d);
					Vector3f().copyTo(_mc_virtual_att_sp.thrust_body);
					Quatf().copyTo(_v_att_sp.q_d);
					Vector3f().copyTo(_v_att_sp.thrust_body);
				}

https://github.com/PX4/Firmware/blob/master/src/modules/vtol_att_control/vtol_att_control_main.cpp#L415

I want to remove it, do you have any idea?

@xdwgood
Copy link
Contributor Author

xdwgood commented Oct 16, 2019

fix : #13198

@MaEtUgR
Copy link
Member

MaEtUgR commented Oct 16, 2019

Here's the first attempt of the proper solution: #13210
But that one needs more corner-case testing.

@xdwgood xdwgood reopened this Nov 9, 2019
@xdwgood
Copy link
Contributor Author

xdwgood commented Nov 9, 2019

@MaEtUgR The latest master branch, this feature is broken again
https://logs.px4.io/plot_app?log=8c7b8d4e-42b7-4fa9-9ed7-5d364a133f19

@xdwgood
Copy link
Contributor Author

xdwgood commented Nov 10, 2019

see here: #13210

@xdwgood xdwgood closed this as completed Nov 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants