MC pos control - Dynamically constrain parameters #12404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bresch
changed the title
|
Looks good, one minor thing I'm wondering is if the wording should be changed slightly to imply it has been changed. The concern being that the user sees the message, goes to change the parameter, but is then confused because |
hover thrust between min and max thrust
|
@dagar You are right, I reworded the message. |
bkueng
approved these changes
Jul 4, 2019
dagar
approved these changes
Jul 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've seen a few times now that some people adjust
MPC_XY_VEL_MAXto reduce the speed of the vehicle. The problem is that ifMPC_VEL_MANUALorMPC_XY_CRUISEare larger than the max speed, some problems will appear.I also did a check for the hover thrust to fix #12338