-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add script for VoxForge data preparation. #16
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost LGTM
README.md
Outdated
@@ -506,6 +506,8 @@ VoxForge European | 31.21 | 20.47 | |||
VoxForge Indian | 56.79 | 28.15 | |||
Baidu Internal Testset | 47.73 | 8.92 | |||
|
|||
For reproducing benchmark results on VoxForge data, we provide a script to generate VoxForge dialect manifest files. Please go to ```data/voxforge``` and execute ```sh run_data.sh``` to get VoxForge dialect manifest files. Notice that VoxForge data may keep updated and the generated manifest files may have difference from those we evaluated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we provide a script to generate VoxForge dialect manifest files
-> we provide a script to download data and generate VoxForge dialect manifest files
may keep updated
-> may keep updating
we evaluated
-> we evaluated on
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
data/voxforge/run_data.sh
Outdated
|
||
# download data, generate manifests | ||
PYTHONPATH=.:$PYTHONPATH python data/voxforge/voxforge.py \ | ||
--manifest_prefix='data/voxforge/manifest' \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that run the script in the same directory, cd ../.. > /dev/null
and the prefix data/voxforge
won't be necessary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Resolves #9