-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Paddle docker build readme need to illustrate how to test paddle. Current implementation of test is not correct. #1674
Comments
Well currently it's the only way to run tests in |
Encounterd a strange issue when running build and test in
|
@gangliao ^^ could you please check above comment? |
@typhoonzero I think @gangliao is familiar with cmake as well, maybe he can give some suggestions. |
@helinwang I've talked with @gangliao . we'll try to figure out a solution later. |
I tried to use production image for test, after making
Maybe this can be a direction to solve the problem: copy everything unit test need into |
Feel free to reopen it. |
Currently readme only mentioned "test" in this command
But there is no explanation about how will the test be performed. E.g., will the test run during building docker image
paddle:dev
, or later when paddle is building the final output image.Current implementation is paddle will run test inside
paddle:dev
image, which is incorrect. Since the environment maybe different from the final image. Actually I encountered this problem: the test fails inpaddle:dev
since the numpy version forpaddle:dev
is too old, but the numpy version is good in the final produced image.The text was updated successfully, but these errors were encountered: