Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename WITH_C_API into PADDLE_BUILD_INFERENCE_LIB #7578

Closed
wangkuiyi opened this issue Jan 16, 2018 · 1 comment
Closed

Rename WITH_C_API into PADDLE_BUILD_INFERENCE_LIB #7578

wangkuiyi opened this issue Jan 16, 2018 · 1 comment
Assignees
@luotao1 @Xreki

Comments

@wangkuiyi
Copy link
Collaborator

The term C_API has been pretty confusing. By reading our source code, I think it means the C-API for inference only, but not those for training. Let us use an accurate name for it.
@luotao1
Copy link
Contributor

luotao1 commented Jan 17, 2018

As WITH_C_API is used for a long time in old PaddlePaddle, users are familiar with it, we may remain it. And for fluid, we will add WITH_FLUID option for both training and inference.

@luotao1 luotao1 closed this as completed Jan 17, 2018
@luotao1 luotao1 mentioned this issue Jan 17, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@luotao1 luotao1

@Xreki Xreki

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@wangkuiyi @luotao1 @Xreki