Hostpath volume #60
Hostpath volume #60
Conversation
paddlecloud/paddlecloud/settings.py
Outdated
| #DATACENTERS = { | ||
| # ... | ||
| # "dc1":{ | ||
| # "type": "hostpath", |
There was a problem hiding this comment.
Maybe fstype is better?
paddlecloud/paddlecloud/settings.py
Outdated
| @@ -270,6 +270,15 @@ | |||
| # "admin_key": "/certs/admin.secret" | |||
There was a problem hiding this comment.
Should contain type in this example.
There was a problem hiding this comment.
type => fstype
Done.
paddlecloud/paddlejob/views.py
Outdated
| )) | ||
| if dc == name: | ||
| if cfg["type"] == "cephfs": | ||
| volumes.append(CephFSVolume( |
There was a problem hiding this comment.
Check if monitors_addr user secret exists. Return an error code when parameters not found.
There was a problem hiding this comment.
These parameters are in settings.py, I think we can check the configurations at the start-up phase of the cloud server. And maybe implement this feature in another PR is suitable.
| @@ -0,0 +1,4 @@ | |||
| from cephfs_volume import CephFSVolume | |||
There was a problem hiding this comment.
It seems package volume is too small to exist. We can have:
def get_volume_config(**kwargs):
__check_parameters(kwargs)
tmpl = __get_template(kwargs["type"])
return json.loads(__render(tmpl, kwargs))There was a problem hiding this comment.
Good point！I have use templates instead of package volume.Thanks a lot!
Done.
paddlecloud/paddlejob/volume.py
Outdated
| } | ||
|
|
||
| def __render(tmpl, **kwargs): | ||
| tmpl.replace("$NAME", "sfsdf") |
There was a problem hiding this comment.
This line is not needed.
Fixed #51