-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make edl controller jobparser workable #7
Conversation
example/examplejob.yaml
Outdated
name: example | ||
spec: | ||
#image: "paddlepaddle/paddlecloud-job" | ||
image: "typhoon1986/paddlecloud-job:wuyitest" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we can keep the official Docker image.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
kind: Deployment | ||
metadata: | ||
name: training-job-controller | ||
namespace: paddlecloud |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need to create the namespace before this yaml can claim?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed. We should update the documents later.
excellent! I was trying the same yesterday to make the whole thing work. also, to make the training job work as CRD, do we just need to change the yaml(thirdpartyresource.yaml) or there are go code need to change with that? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! LGTM++
WORKDIR $GOPATH/src/github.com/paddlepaddle/edl | ||
RUN glide install --strip-vendor | ||
ADD . $GOPATH/src/github.com/paddlepaddle/edl |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! This is the correct solution.
edl_controller.yaml
Outdated
containers: | ||
- name: training-job-controller | ||
image: paddlepaddle/edl-controller | ||
imagePullPolicy: Never |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we change the policy to IfNotPresent
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
User cert management
@putcn Yes, I'm afraid we have to put the CRD implement in another branch, it should have a lot of difference from this one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Fix #6 and add some examples.