Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Creates select component #338

Merged
merged 42 commits into from
Sep 21, 2020
Merged

feat: Creates select component #338

merged 42 commits into from
Sep 21, 2020

Conversation

eltongarbin
Copy link
Contributor

@eltongarbin eltongarbin commented Sep 11, 2020 •
edited
Loading

@eltongarbin eltongarbin added the enhancement New feature or request label Sep 11, 2020
@eltongarbin eltongarbin added this to the v0.2.0 - Atoms milestone Sep 11, 2020
@eltongarbin eltongarbin self-assigned this Sep 11, 2020
@eltongarbin eltongarbin force-pushed the select-component branch 3 times, most recently from 25dd3d6 to 94cf060 Compare September 12, 2020 15:16
@eltongarbin eltongarbin marked this pull request as ready for review September 14, 2020 13:40
lhas-dev
lhas-dev approved these changes Sep 16, 2020
View reviewed changes
package.json Show resolved Hide resolved
src/FormControl/FormControl.tsx Show resolved Hide resolved
src/FormLabel/styles/form-label.scss Show resolved Hide resolved
src/Select/Option.tsx Outdated Show resolved Hide resolved
@eltongarbin eltongarbin force-pushed the select-component branch 2 times, most recently from c1ba5c5 to 02c86d1 Compare September 18, 2020 20:36
leonardoalemax
leonardoalemax approved these changes Sep 21, 2020
View reviewed changes
Copy link
Contributor

@leonardoalemax leonardoalemax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Da próxima vez só divide os ajustes em outro pr pra facilitar a vida 34 arquivos é muita coisa pra ler mano. rsrsr.

@codeclimate
Copy link

codeclimate bot commented Sep 21, 2020

Code Climate has analyzed commit 381e5fa and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (100% is the threshold).

This pull request will bring the total coverage in the repository to 100.0% (0.0% change).

View more on Code Climate.

@sonarcloud
Copy link

sonarcloud bot commented Sep 21, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@eltongarbin eltongarbin merged commit f6a8d8d into master Sep 21, 2020
@eltongarbin eltongarbin deleted the select-component branch September 21, 2020 12:49
eltongarbin added a commit that referenced this pull request Oct 2, 2020
@eltongarbin
feat: Creates select component (#338)
37915a0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leonardoalemax leonardoalemax leonardoalemax approved these changes

@lhas-dev lhas-dev lhas-dev approved these changes

Assignees

@eltongarbin eltongarbin

Labels
enhancement New feature or request
Projects
None yet
Milestone
v0.2.0 - Atoms
Development

Successfully merging this pull request may close these issues.
3 participants
@eltongarbin @leonardoalemax @lhas-dev