Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept only bool for $exists in LiveQuery #1315

Merged
merged 1 commit into from
Apr 1, 2016

Conversation

drew-gross
Copy link
Contributor

No description provided.

@codecov-io
Copy link

Current coverage is 93.04%

Merging #1315 into master will decrease coverage by -0.02% as of 802c9c1

@@            master   #1315   diff @@
======================================
  Files           84      84       
  Stmts         5303    5304     +1
  Branches       969     970     +1
  Methods          0       0       
======================================
  Hit           4935    4935       
  Partial         11      11       
- Missed         357     358     +1

Review entire Coverage Diff as of 802c9c1

Powered by Codecov. Updated on successful CI builds.

@@ -208,6 +208,11 @@ function matchesKeyConstraints(object, key, constraints) {
case '$exists':
let propertyExists = typeof object[key] !== 'undefined';
let existenceIsRequired = constraints['$exists'];
if (typeof constraints['$exists'] !== 'boolean') {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could use existenceIsRequired but otherwise LGTM

@flovilmart flovilmart merged commit 02af61d into parse-community:master Apr 1, 2016
@drew-gross drew-gross deleted the bool-only branch April 1, 2016 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants