Completely migrate SchemasRouter to new MongoCollection API. #794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Failing tests |
nlutsenko
force-pushed
the
nlutsenko.schemasRouter
branch
from
a34963c
to
b97160b
Compare
|
@nlutsenko updated the pull request. |
facebook-github-bot
added
GH Review: review-needed
and removed
GH Review: needs-revision
labels
nlutsenko
force-pushed
the
nlutsenko.schemasRouter
branch
from
b97160b
to
99cb05e
Compare
|
@nlutsenko updated the pull request. |
|
Doesn't fail anymore. |
|
Plz don't merge until after 2.1.4 |
nlutsenko
added a commit
that referenced
this pull request
Mar 3, 2016
Completely migrate SchemasRouter to new MongoCollection API.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No more usages of non-adaptive collection in SchemasRouter. Woohoo!
There is a bunch of stuff left, but we are a big step closer.