Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add database options to ParseServer constructor and pass to MongoStorageAdapter #956

Merged
merged 2 commits into from
Mar 11, 2016

Conversation

steven-supersolid
Copy link
Contributor

This should allow being able to pass options when connecting to MongoDB, such as setting the connection pool size.

@codecov-io
Copy link

Current coverage is 90.67%

Merging #956 into master will decrease coverage by -0.68% as of 01286ef

@@            master    #956   diff @@
======================================
  Files           73      73       
  Stmts         4324    4398    +74
  Branches       863     880    +17
  Methods          0       0       
======================================
+ Hit           3950    3988    +38
  Partial         10      10       
- Missed         364     400    +36

Review entire Coverage Diff as of 01286ef

Powered by Codecov. Updated on successful CI builds.

@flovilmart
Copy link
Contributor

@steven-supersolid could you add a few tests there to make sure the adapter is loaded with the proper options etc...

@facebook-github-bot
Copy link

@steven-supersolid updated the pull request.

@flovilmart
Copy link
Contributor

LGTM

flovilmart added a commit that referenced this pull request Mar 11, 2016
Add database options to ParseServer constructor and pass to MongoStorageAdapter
@flovilmart flovilmart merged commit 2c991a4 into parse-community:master Mar 11, 2016
@steven-supersolid steven-supersolid deleted the steven.dboptions branch March 17, 2016 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants