Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: Update to use default npm caching #348

Closed
GaryJones opened this issue Jul 3, 2021 · 1 comment
Closed

CI: Update to use default npm caching #348

GaryJones opened this issue Jul 3, 2021 · 1 comment
Assignees
@pauarge
Labels
Type: Maintenance
Milestone
2.6.0

Comments

@GaryJones
Copy link
Contributor

https://github.blog/changelog/2021-07-02-github-actions-setup-node-now-supports-dependency-caching/

Review whether we can update our node GitHub Actions workflow to make use of this caching, and remove the extra caching step that exists.
@GaryJones GaryJones added this to the 2.6.0 milestone Jul 3, 2021
@pauarge
Copy link
Contributor

pauarge commented Sep 20, 2021

We're actually already using this on the E2E tests:

wp-parsely/.github/workflows/e2e-tests.yml

Line 29 in cf54b1f

cache: 'npm'

@pauarge pauarge mentioned this issue Sep 20, 2021
Merged
@pauarge pauarge self-assigned this Sep 21, 2021
@pauarge pauarge closed this as completed Sep 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pauarge pauarge

Labels
Type: Maintenance
Projects
None yet
Milestone
2.6.0
Development

No branches or pull requests
2 participants
@GaryJones @pauarge