Better feature branch support #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@andreasohlund can you review, make sure it doesn't break any of your workflows |
| @@ -29,7 +29,7 @@ public static void AppendLineFormat(this StringBuilder stringBuilder, string for | |||
|
|
|||
| public static string TrimStart(this string value, string toTrim) | |||
| { | |||
| if (!value.StartsWith(toTrim)) | |||
| if (!value.StartsWith(toTrim, StringComparison.InvariantCultureIgnoreCase)) | |||
There was a problem hiding this comment.
I think fody does this already?
There was a problem hiding this comment.
Yup
Sent from my iPhone
On 07 Jun 2014, at 13:18, Jake Ginnivan notifications@github.com wrote:
In GitVersionCore/ExtensionMethods.cs:
@@ -29,7 +29,7 @@ public static void AppendLineFormat(this StringBuilder stringBuilder, string for
public static string TrimStart(this string value, string toTrim) {
if (!value.StartsWith(toTrim))if (!value.StartsWith(toTrim, StringComparison.InvariantCultureIgnoreCase))—
Reply to this email directly or view it on GitHub.
|
👍 |
|
Looks good to me (we're not using feature branches) Sent from my iPhone
|
JakeGinnivan
added a commit
that referenced
this pull request
Jun 9, 2014
Better feature branch support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternate way to solve what #184 is solving