Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing to core-js for polyfills cause annotation inheritance to break in angular2 #450

Closed
user414 opened this issue Mar 21, 2016 · 3 comments

Comments

@user414
Copy link

user414 commented Mar 21, 2016

I'm sure it's a side effect of something else, but restoring es6-shim instead of core-js polyfills fix it for me. Here is the angular2 issue with plunker

angular/angular#5415

@user414
Copy link
Author

user414 commented Mar 22, 2016

Another observation is that the mangling that was turned on with the except also break the annotation inheritance so add to remove that from the prod configuration as well

@user414 user414 changed the title Changing to zone-js for polyfills cause annotation inheritance to break in angular2 Changing to core-js for polyfills cause annotation inheritance to break in angular2 Mar 31, 2016
@abadakhshan
Copy link

hi
How your "@ViewChild in base class in Webpack (angular cli)" problem solved?
I have similar problem
tanx

@user414
Copy link
Author

user414 commented Dec 18, 2016

@abadakhshan look at this thread

angular/angular#5415

particularly comments

angular/angular#5415 (comment)
angular/angular#5415 (comment)

We kept using es6-shim instead of core-js. However, saw recently that this was finally implemented in the latest trunk/beta

angular/angular#11606

via this commit

angular/angular@f5c8e09

and have not tried it since. There's a high likelihood that the workaround and/or using es6-shim instead of core-js is no longer needed but have not tried it yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants