Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Srtanh #16

Closed
wants to merge 12 commits into from
Closed

Srtanh #16

wants to merge 12 commits into from

Conversation

yyang606
Copy link

@yyang606 yyang606 commented Dec 7, 2023

Please review the developer documentation
on the wiki of this project that contains help and requirements.

Proposed changes

Describe what this PR changes and why. If it closes an issue, link to it here
with a supported keyword.

What type(s) of changes does this code introduce?

Delete the items that do not apply

  • Other (please describe): made the number of positive and negative terms in the sum of images expression equal to facilitate convergence.

Does this introduce a breaking change?

  • No

What systems has this change been tested on?

Checklist

Update the following with a yes where the items apply. If you're unsure about any of them, don't hesitate to ask. This is
simply a reminder of what we are going to look for before merging your code.

  • No. This PR is up to date with current the current state of 'develop'
  • Yes/No. Code added or changed in the PR has been clang-formatted
  • No. This PR adds tests to cover any new code, or to catch a bug that is being fixed
  • No. Documentation has been added (if appropriate)

@yyang606
Copy link
Author

yyang606 commented Dec 7, 2023

Made the number of positive and negative terms in the sum of images expression equal to facilitate convergence.

@Paul-St-Young
Copy link
Owner

This PR is made on top of an old commit.
@yyang606 Please first pull all changes from the mch branch and then make your change to Screen2D.cpp.
The "Files Changed" tab should contain only a single file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants