Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't bother editing the test file #4

Closed
coriolinus opened this issue Nov 13, 2020 · 3 comments
Closed

don't bother editing the test file #4

coriolinus opened this issue Nov 13, 2020 · 3 comments
Labels
enhancement New feature or request track-script Related to a track's script

Comments

@coriolinus
Copy link

xr/tracks/rust.sh

Lines 3 to 4 in 57d5b05

sed -i 's/#\[ignore\]$//g' tests/*.rs \
&& cargo +nightly test --all-features

Given that you're already using a nightly compiler, it's simpler to just do

cargo +nightly test --all-features -- --include-ignored
@PaulDance PaulDance added the enhancement New feature or request label Nov 13, 2020
@PaulDance
Copy link
Owner

Hey @coriolinus, thanks for taking the time to go into such details!

I actually already knew about this --include-ignored option of the test runner, but when mentoring, I like to remove the #[ignore] tags entirely so I may use cargo with usual arguments at any time. Do you think that's overkill? Would it be bad if I kept it this way?

@coriolinus
Copy link
Author

My take is that life is simpler when you don't have to edit things. In WSL in particular, transient filesystem errors occur frequently, and make that into a pain.

@PaulDance
Copy link
Owner

Okay then, I'll follow that advice!

@PaulDance PaulDance added the track-script Related to a track's script label Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request track-script Related to a track's script
Projects
None yet
Development

No branches or pull requests

2 participants