Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Service Defenition For Symfomy v.3.2.x #455

Open
nickworker opened this issue Jan 12, 2018 · 4 comments
Open

Service Defenition For Symfomy v.3.2.x #455

nickworker opened this issue Jan 12, 2018 · 4 comments

Comments

@nickworker
Copy link

nickworker commented Jan 12, 2018

Hi.
This tag https://github.com/Payum/PayumBundle/blob/master/Resources/config/payum.xml#L19
is not compatible with symfony v.3.2.x

@Timo-Linde
Copy link

Hello,
i have these issues too with symfony v.3.1.x

Unable to parse file "/vendor/payum/payum-bundle/DependencyInjection/../Resources/config/payum.xml".

@lashus
Copy link

lashus commented Mar 16, 2018

Pinging @makasim . Should we open PR?

@makasim
Copy link
Member

makasim commented Mar 16, 2018

Pinging @makasim . Should we open PR?

It would be great.

@lashus
Copy link

lashus commented Mar 16, 2018

@makasim I have another issue though. The version 2.2.1 works fine with symfony 3.x although version 2.3 has more issues - for ex. ChildDefinition doesn't exist yet (it still has DefinitionDecorator for DIC).

The question is - do we introduce BC and detect which class should be used? Because for symfony 4.x the deprecation notice or error will be displayed for DefinitionDecorator class.

see: https://github.com/Payum/PayumBundle/blob/master/DependencyInjection/Factory/Storage/DoctrineStorageFactory.php#L44

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants