Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Payum\Core\Bridge\Symfony\Reply\HttpResponse is not catchable in ReplyToSymfonyResponseConverter anymore #568

Open
jkabat opened this issue Dec 16, 2024 · 2 comments · May be fixed by #567
Assignees
Labels
Milestone

Comments

@jkabat
Copy link

jkabat commented Dec 16, 2024

After recent upgrade (Symfony v6.4, maybe even Payum) Im having an issue with creating response using

Payum\Core\Bridge\Symfony\Reply\HttpResponse

Error comes from [ReplyToSymfonyResponseConverter.php]:

Cannot convert reply HttpResponse to http response.

I had to change response to Payum\Bundle\PayumBundle\Reply\HttpResponse to be catchable.

Anybody else is getting the same issue?

@jkabat
Copy link
Author

jkabat commented Dec 16, 2024

Seems like it relates to this PR #557

Autowired is PayumBundle service ReplyToSymfonyResponseConverter, which does not catch the same response classes... that is a BC IMHO.

@pierredup
Copy link
Member

pierredup commented Dec 26, 2024

Thanks for the report, this will be fixed in #567

@pierredup pierredup transferred this issue from Payum/Payum Dec 26, 2024
@pierredup pierredup linked a pull request Dec 26, 2024 that will close this issue
@pierredup pierredup added the bug label Dec 26, 2024
@pierredup pierredup added this to the 2.6.1 milestone Dec 26, 2024
@pierredup pierredup self-assigned this Dec 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants