Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set env variables in docker-compose to be used with interface and visualization parts of the app #72

Open
im-prakher opened this issue Nov 8, 2020 · 1 comment
Open

Set env variables in docker-compose to be used with interface and visualization parts of the app #72

im-prakher opened this issue Nov 8, 2020 · 1 comment
Assignees
@eshantri
Labels
good first issue Good for newcomers

Comments

@im-prakher
Copy link
Contributor

im-prakher commented Nov 8, 2020 •
edited
Loading

Would it make sense to set environment variables here that reference the other YABA server addresses that can be accessed through ReactJS's process.env? This way only one place needs to change if the server information changes

Originally posted by @Chris-Schnaufer in #69 (comment)

The aim of this issue is to set port and host environment variables for the interface and visualization part in the docker-compose file itself so that can be used in these parts through ReactJS's and Node.js process.env

For reference- Reading an environment variable in react which was set by docker
@im-prakher im-prakher mentioned this issue Nov 8, 2020
Merged
@im-prakher im-prakher added the good first issue Good for newcomers label Feb 3, 2021
@eshantri
Copy link
Contributor

I'd like to work on this issue.

@eshantri eshantri mentioned this issue Mar 19, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eshantri eshantri

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@im-prakher @eshantri