Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes needed for gradle 3.0.1 compatibility #9

Closed
pacamara opened this issue Jan 19, 2018 · 2 comments
Closed

Changes needed for gradle 3.0.1 compatibility #9

pacamara opened this issue Jan 19, 2018 · 2 comments

Comments

@pacamara
Copy link

Some minor changes are needed for gradle 3.0.1 compatibility: in android/build.gradle:

We are currently hacking these changes with a script in status.im, and would rather it is fixed upstream. Thanks!

Parent issue: status-im/status-mobile#3037

@phillbaker
Copy link

phillbaker commented Mar 30, 2018

Hi @pacamara, I recently received access to update this package on NPM, but don't have access to this repo on github. We're going to be supporting this package at https://github.com/aprock/react-native-os. Would you mind open this issue there or maybe updating the source with a PR?

@pacamara
Copy link
Author

pacamara commented Apr 4, 2018

Hi @phillbaker , thanks. A PR has now been opened for this upstream against react-native: facebook/react-native#17747

I'd suggest the gradle upgrade for react-native-os is postponed until such time that gets merged, please see discussion at software-mansion/react-native-svg#581

@pacamara pacamara closed this as completed Apr 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants