Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow init_asl_t1_trans_wf to accept flexible set of native-space inputs to warp #341

Closed
tsalo opened this issue Nov 9, 2023 · 2 comments · Fixed by #338
Closed

Allow init_asl_t1_trans_wf to accept flexible set of native-space inputs to warp #341

tsalo opened this issue Nov 9, 2023 · 2 comments · Fixed by #338
Labels
refactor Changes to the codebase that don't impact workflow inputs or outputs.

Comments

@tsalo
Copy link
Member

tsalo commented Nov 9, 2023

Summary

The main difference between ASLPrep's init_asl_t1_trans_wf and fMRIPrep's init_bold_t1_trans_wf is the list of native-space files to warp to T1w space. ASLPrep has ASL versions of many of the same files (ref_bold_brain, ref_bold_mask, t1w_brain, t1w_mask, t1w_aseg, t1w_aparc, bold_split), but it also has a bunch of CBF outputs to warp as well.

If the workflow could ingest multiple native-space inputs without having to specify them in the function, then ASLPrep could directly use fMRIPrep's function (perhaps moved to niworkflows?).

@tsalo tsalo added the refactor Changes to the codebase that don't impact workflow inputs or outputs. label Nov 9, 2023
@tsalo
Copy link
Member Author

tsalo commented Nov 9, 2023

One additional difference is that init_asl_t1_trans_wf calls the ASL reference workflow, which in turn uses aslcontext.

@tsalo
Copy link
Member Author

tsalo commented Nov 9, 2023

I have a plan: I will call the BOLD versions, but ignore the reference image output. Then I will call the ASL-specific reference workflow in the main workflow instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Changes to the codebase that don't impact workflow inputs or outputs.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant