Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RF] Review BIDS compliance of outputs #517

Closed
tsalo opened this issue Sep 23, 2022 · 3 comments · Fixed by #553
Closed

[RF] Review BIDS compliance of outputs #517

tsalo opened this issue Sep 23, 2022 · 3 comments · Fixed by #553
Assignees
Labels
breaking-change PRs that change results or interfaces. enhancement New feature or request

Comments

@tsalo
Copy link
Member

tsalo commented Sep 23, 2022

Summary

At a glance, all of the functional derivatives seem to have a bold suffix- even things like time series TSV files.

Additional details

While functional derivatives aren't currently well supported in the main specification, BEP012 has been pretty stable for a while now, and I believe it's been adopted by fMRIPrep. We can refer to bids-standard/bids-specification#519 for inspiration.

@tsalo tsalo added the enhancement New feature or request label Sep 23, 2022
@tsalo
Copy link
Member Author

tsalo commented Sep 23, 2022

Just a first pass:

  • _desc-timeseries_bold.tsv --> _timeseries.tsv
    • Should have column headers and a sidecar file explaining the columns.
  • _desc-connectivity_bold.tsv --> _measure-pearsoncorrelation_conmat.tsv or something similar. Based on BEP017.
    • Also may require metadata fields to label rows and columns, or _nodelabels file(s).
  • _desc-framewisedisplacement_bold.tsv --> _desc-framewisedisplacement_motion.tsv
  • _tmask.tsv --> _outliers.tsv
  • _desc-alff_bold.nii.gz --> _alff.nii.gz
  • _desc-alff_smooth_bold.nii.gz --> _desc-smooth_alff.nii.gz
  • _desc-reho_bold.nii.gz --> _reho.nii.gz
  • _desc-reho_smooth_bold.nii.gz --> _desc-smooth_reho.nii.gz
  • _desc-residual_bold.nii.gz --> _desc-denoised_bold.nii.gz
  • _desc-residual_smooth_bold.nii.gz --> _desc-denoisedSmoothed_bold.nii.gz
  • _desc-qc_bold.csv --> This isn't BIDS-ish. I'd recommend putting these metrics in the denoised BOLD file's JSON, like MRIQC does. Then analysis_level = "group" would collect the outputs into a TSV file at the top of the derivative directory.

@mattcieslak
Copy link
Contributor

possibly make a session-level TSV that has all the metrics. Maybe scans.tsv. Maybe roadmap for now

@kahinimehta
Copy link
Collaborator

kahinimehta commented Oct 3, 2022

Makes sense! Also:

  • make the *conn.nii --> to .tsv for cifti correlations

@kahinimehta kahinimehta changed the title Review BIDS compliance of outputs [RF] Review BIDS compliance of outputs Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change PRs that change results or interfaces. enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants