Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure full AssertJ migrateability #33

Open
Philzen opened this issue Jun 16, 2024 · 0 comments
Open

Ensure full AssertJ migrateability #33

Philzen opened this issue Jun 16, 2024 · 0 comments
Labels
Help wanted Extra attention is needed must-have Question Further information is requested

Comments

@Philzen
Copy link
Owner

Philzen commented Jun 16, 2024

Although technically out of scope, many people would prefer their assertions to be assertJ-style in their project, either before or after applying the TestNG → Jupiter recipe.

The migration of the expectedExceptions and expectectedExceptionsMessageRegExp attributes as well as SkipExceptions would create JUnit-assertions/assumptions.

Possible approaches:

  1. Implement a variant of the existing recipe
    • 👍 simple and straightforward
    • 👎 creates a second recipe list that would involve lots of duplicated code
  2. Add input variables to the recipe (list), default being JUnit5-style, input option to use AssertJ
    • ❔ how would that be implemented
    • 👍 no code duplication
    • 👍 ideal performance
    • 👎 not straightforward for users, so we would wrap this into two recipe lists which comes down to 1.
  3. Advise to run the TestNG → AssertJ assertions recipe after
@Philzen Philzen added Help wanted Extra attention is needed must-have Question Further information is requested labels Jun 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Help wanted Extra attention is needed must-have Question Further information is requested
Projects
Status: Backlog
Development

No branches or pull requests

1 participant