Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

插件对于报错信息的不正确处理 #99

Closed
JeffersonQin opened this issue Aug 20, 2021 · 5 comments · Fixed by PicGo/PicGo-Core#96
Closed

插件对于报错信息的不正确处理 #99

JeffersonQin opened this issue Aug 20, 2021 · 5 comments · Fixed by PicGo/PicGo-Core#96

Comments

@JeffersonQin
Copy link

  • vs-picgo: 2.1.3
  • VSCode Version: 1.57.1 (system setup)
  • Commit: 507ce72a4466fbb27b715c3722558bb15afa9f48
  • Date: 2021-06-17T13:28:07.755Z
  • Electron: 12.0.7
  • Chrome: 89.0.4389.128
  • Node.js: 14.16.0
  • V8: 8.9.255.25-electron.0
  • OS: Windows_NT x64 10.0.19042

image

在失败的情况下还是显示上传成功.

（这是我在调试别的bug的时候发现的，其他bug会另行汇报）
@upupming
Copy link
Member

upupming commented Aug 20, 2021 •
edited
Loading

这个是文件名有错误吗？这个属于是 picgo-core 的报错系统 handle 的有点问题，我周末看看。抱歉现在才回复，邮件进了垃圾箱

这个错误的重现方式是啥哈，可以提供一下吗

@JeffersonQin
Copy link
Author

其实就是当剪切板文件路径获取有问题时就能重现。你可以在拿到文件路径后做一下判断，文件是否存在。

@upupming
Copy link
Member

upupming commented Aug 21, 2021 •
edited
Loading

@JeffersonQin 不是很懂，怎么复现才能使出剪切板文件路径有问题
我知道了，我来修改一下吧

@JeffersonQin
Copy link
Author

我前面看了一下代码，可能这个issue在Core里，不在这里。就是好像Core没有对脚本的报错做进一步处理

This was referenced Aug 21, 2021
Merged
Merged
@JeffersonQin
Copy link
Author

@upupming 谢谢，我大概了解了，我等会去Core在提一下（确实有点问题，因为script的脚本过于native，不是很好handle

@JeffersonQin JeffersonQin mentioned this issue Aug 21, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

🐛 Fix(error): throw error when transform failed PicGo/PicGo-Core
2 participants
@upupming @JeffersonQin