[Bug]: Watch-video-playlist does not update as additions/removals are made to playlist

[kommunarr]

Guidelines

• I have encountered this bug in the latest release of FreeTube.
• I have searched the issue tracker for a bug report that matches the one I want to file, without success.
• I have searched the documentation for information that matches the description of the bug I want to file, without success.

Describe the bug

Case 1: Adding videos

1. Create a playlist with three videos.
2. Open a video of that playlist from the Playlist tab.
3. Add a video from the Recommended Videos, or the current video, to the current playlist using the + "Add to playlist" button.
4. See that the watch-video-area does not update to include the videos added.

Case 2: Removing videos
The same issue also occurs for videos that are removed in another tab. To replicate:

1. Create a playlist with three videos.
2. Open a video of that playlist from the Playlist tab.
3. Open another tab and navigate the Playlist tab.
4. Open that playlist in the playlist tab.
5. Remove a video from the playlist.
6. Switch back to the first tab; notice that the video is still present in the watch-video-playlist.

Expected Behavior

For Case 1, added videos to the playlist should automatically be added to the watch-video-playlist box (regardless of which tab the "Add" was initiated from.

For Case 2, removed videos from the playlist should automatically be removed from the watch-video-playlist box, regardless of which tab the "Remove" was initiated from. The edge case of the currently open video being removed is a unique one; in this one case, I think the removal should not be visibly reflected in the watch-video-playlist box until the route changes.

Issue Labels

visual bug

FreeTube Version

402af7a

Operating System Version

OpenSUSE Tumbleweed

Installation Method

other

Primary API used

Local API

Last Known Working FreeTube Version (If Any)

No response

Additional Information

No response

Nightly Build

• I have encountered this bug in the latest nightly build.

[efb4f5ff-1298-471a-8973-3d47447115dc]

@jasonhenriquez i would recommend link the commit when filling in the FT version.

I know this is just Pikachu's repo so it doesn't matter that much but sometimes pikachu asked me if I'm using latest commit pushed to the branch because the thing i reported was already fixed.

So TLDR including commit you're using will remove confusion of what version you're using and time doenst have to be wasted by pika asking the question and u answering it

[PikachuEXE]

Tried a fix in 125a467

But I think there would still be a lot of related issues regard this

I understand the add/reorder one
But not removing item when it's being played with my implementation can lead to

• Remove current playing entry => playlist not updated
• Remove non current playing entry => new list of video entries still has no current entry => still cannot update the view

[kommunarr]

Removing the item unconditionally is fine if necessary, as long as the watch-video-playlist box is still visible.

Case 1 and 2 are still occurring locally on 25a467.

[PikachuEXE]

I am not sure what's the best
But I would like to revisit this later

[PikachuEXE]

Updated in 7863d03

Currently playing video entry is removed anyway
Video index 0 / N, progress bar empty
Play next = play first video
Play prev = play last video

Don't want too many exceptions handling code

[efb4f5ff-1298-471a-8973-3d47447115dc]

LGTM, Based on the expected behavior Jason laid out.

[efb4f5ff-1298-471a-8973-3d47447115dc]

@jasonhenriquez @jasonhenriquez @jasonhenriquez @jasonhenriquez @jasonhenriquez @jasonhenriquez @jasonhenriquez

[kommunarr]

ya, looks good