Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Piranha.ImageSharp dependency SixLabors.ImageSharp to v3 #2093

Open
jmbryan4 opened this issue Sep 9, 2024 · 3 comments
Open

Update Piranha.ImageSharp dependency SixLabors.ImageSharp to v3 #2093

jmbryan4 opened this issue Sep 9, 2024 · 3 comments
Labels
dependencies Pull requests that update a dependency file request

Comments

@jmbryan4
Copy link

jmbryan4 commented Sep 9, 2024

image
image
update to ImageSharp 3.x see: https://sixlabors.com/posts/announcing-imagesharp-300/

@jmbryan4 jmbryan4 changed the title Piranha.ImageSharp dependency SixLabors.ImageSharp needs updating Update Piranha.ImageSharp dependency SixLabors.ImageSharp to v3 Sep 9, 2024
@tidyui
Copy link
Member

tidyui commented Sep 23, 2024

There are some major changes to the licensing between v2 and v3 of ImageSharp that we need to clear out before being able to update.

@tidyui tidyui added request dependencies Pull requests that update a dependency file labels Sep 23, 2024
@usercode
Copy link

Updating the ImageSharp dependency is also important because of breaking changes between version 2 and 3.

I use Piranha CMS with other open source library which target the version 3.x.

If I try to upload an image with the manager, I get this error message.

grafik

I think there is no license issue. (It's allowed to use ImageSharp as "Transitive Package Dependency" by open source projects like Piranha CMS.)

https://github.com/SixLabors/ImageSharp/blob/main/LICENSE

@tidyui
Copy link
Member

tidyui commented Oct 21, 2024

@usercode We can't upgrade ImageSharp to a new major version with breaking changes without changing major version for Piranha itself. If you need to upgrade to the latest version of ImageSharp in your project before this it's very easy to create your own local pre-release version of Piranha.ImageSharp and reference you local package in your project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file request
Projects
None yet
Development

No branches or pull requests

3 participants