Skip to content

Commit

Permalink
Fix typos in CMakeLists.txt files
Browse files Browse the repository at this point in the history
   - usdValidation was not being build as the PXR_BUILD_USD_VALIDATION config was not correctly set
   - Update PXR_PREFIX and PXR_PACKAGE for usdValidation and usdchecker
   - add module.cpp to pxr/usdValidation/usdValidation/CMakeLists.txt
   - Generate pch.h for windows builds.

(Internal change: 2349786)
(Internal change: 2349792)
  • Loading branch information
tallytalwar authored and pixar-oss committed Dec 6, 2024
1 parent 5810429 commit 1f0b71a
Show file tree
Hide file tree
Showing 9 changed files with 72 additions and 5 deletions.
2 changes: 1 addition & 1 deletion pxr/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ if (EXISTS "${PROJECT_SOURCE_DIR}/pxr/exec")
add_subdirectory(exec)
endif()

if ($(PXR_BUILD_USD_VALIDATION))
if (${PXR_BUILD_USD_VALIDATION})
add_subdirectory(usdValidation)
endif()

Expand Down
4 changes: 2 additions & 2 deletions pxr/usdValidation/bin/usdchecker/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@ if (NOT BUILD_SHARED_LIBS)
return()
endif()

set(PXR_PREFIX pxr/usd)
set(PXR_PACKAGE usd)
set(PXR_PREFIX pxr/usdValidation)
set(PXR_PACKAGE usdchecker)

pxr_cpp_bin(usdchecker
LIBRARIES
Expand Down
13 changes: 13 additions & 0 deletions pxr/usdValidation/usdGeomValidators/pch.h
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
//
// Copyright 2017 Pixar
//
// Licensed under the terms set forth in the LICENSE.txt file available at
// https://openusd.org/license.
//
// WARNING: THIS FILE IS GENERATED. DO NOT EDIT.
//

#include "pxr/pxr.h"
#include <algorithm>
#include <string>
#include <vector>
13 changes: 13 additions & 0 deletions pxr/usdValidation/usdShadeValidators/pch.h
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
//
// Copyright 2017 Pixar
//
// Licensed under the terms set forth in the LICENSE.txt file available at
// https://openusd.org/license.
//
// WARNING: THIS FILE IS GENERATED. DO NOT EDIT.
//

#include "pxr/pxr.h"
#include <algorithm>
#include <unordered_map>
#include <vector>
12 changes: 12 additions & 0 deletions pxr/usdValidation/usdSkelValidators/pch.h
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
//
// Copyright 2017 Pixar
//
// Licensed under the terms set forth in the LICENSE.txt file available at
// https://openusd.org/license.
//
// WARNING: THIS FILE IS GENERATED. DO NOT EDIT.
//

#include "pxr/pxr.h"
#include <algorithm>
#include <unordered_set>
11 changes: 11 additions & 0 deletions pxr/usdValidation/usdUtilsValidators/pch.h
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
//
// Copyright 2017 Pixar
//
// Licensed under the terms set forth in the LICENSE.txt file available at
// https://openusd.org/license.
//
// WARNING: THIS FILE IS GENERATED. DO NOT EDIT.
//

#include "pxr/pxr.h"

2 changes: 1 addition & 1 deletion pxr/usdValidation/usdUtilsValidators/validators.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
#include "pxr/usdValidation/usdValidation/error.h"
#include "pxr/usdValidation/usdValidation/registry.h"

#include <pxr/usd/sdf/fileFormat.h>
#include "pxr/usd/sdf/fileFormat.h"

PXR_NAMESPACE_OPEN_SCOPE

Expand Down
4 changes: 3 additions & 1 deletion pxr/usdValidation/usdValidation/CMakeLists.txt
Original file line number Diff line number Diff line change
@@ -1,11 +1,12 @@
set(PXR_PREFIX pxr/usd)
set(PXR_PREFIX pxr/usdValidation)
set(PXR_PACKAGE usdValidation)

pxr_library(usdValidation
LIBRARIES
sdf
plug
tf
usd
work
${TBB_tbb_LIBRARY}

Expand All @@ -29,6 +30,7 @@ pxr_library(usdValidation
moduleDeps.cpp

PYMODULE_CPPFILES
module.cpp
wrapContext.cpp
wrapError.cpp
wrapRegistry.cpp
Expand Down
16 changes: 16 additions & 0 deletions pxr/usdValidation/usdValidation/pch.h
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
//
// Copyright 2017 Pixar
//
// Licensed under the terms set forth in the LICENSE.txt file available at
// https://openusd.org/license.
//
// WARNING: THIS FILE IS GENERATED. DO NOT EDIT.
//

#include "pxr/pxr.h"
#include <algorithm>
#include <memory>
#include <type_traits>
#include <unordered_set>
#include <utility>
#include <vector>

0 comments on commit 1f0b71a

Please sign in to comment.