Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

usdValidation: usdGeom: YUpAxisValidator #3448

Conversation

beersandrew
Copy link
Contributor

Description of Change(s)

  • Moving the existing portion of the StageMetadataChecker from complianceChecker.py that verifies the upAxis is Y
  • Added implementation code, a test, and necessary tokens & plugInfo entries

Link to proposal (if applicable)

Fixes Issue(s)

Note: This PR is a replacement for #3399

Checklist

[X] I have created this PR based on the dev branch

[X] I have followed the coding conventions

[X] I have added unit tests that exercise this functionality (Reference:
testing guidelines)

[X] I have verified that all unit tests pass with the proposed changes

[X] I have submitted a signed Contributor License Agreement (Reference:
Contributor License Agreement instructions)

- Moving the existing portion of the StageMetadataChecker from complianceChecker.py that verifies the upAxis is Y
- Added implementation code, a test, and necessary tokens & plugInfo entries
@jesschimein
Copy link
Collaborator

Filed as internal issue #USD-10491

@jesschimein
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

@tallytalwar tallytalwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of doing a Up axis being Y check, I think this should be a stageMetadataValidator (https://github.com/PixarAnimationStudios/OpenUSD/blob/dev/pxr/usdValidation/usdValidation/coreValidators.cpp) which checks if a upAxis is authored or not and if not error on it.

As for up axis being "y" or not shouldn't be a validator provided with openUSD. It seems from current compliance checker code that thats a arkit/scenekit requirement, and hence should also be part of suite of validators included in scenekit? cc. @dgovil

@beersandrew
Copy link
Contributor Author

Instead of doing a Up axis being Y check, I think this should be a stageMetadataValidator (https://github.com/PixarAnimationStudios/OpenUSD/blob/dev/pxr/usdValidation/usdValidation/coreValidators.cpp) which checks if a upAxis is authored or not and if not error on it.

This one is already covered here. Can this PR be closed?

@tallytalwar
Copy link
Contributor

Yup I think so. Thanks @beersandrew

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants