Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lingering use of boost::shared_ptr in Vt #95

Closed
meshula opened this issue Nov 1, 2016 · 3 comments
Closed

Lingering use of boost::shared_ptr in Vt #95

meshula opened this issue Nov 1, 2016 · 3 comments

Comments

@meshula
Copy link
Member

meshula commented Nov 1, 2016 •
edited
Loading

Any reason Vt_DefaultValueHolder uses a boost::shared_ptr? Can it just be switched to a shared_ptr now? It's the only usage in vt.
@jtran56
Copy link

jtran56 commented Nov 2, 2016

Filed as internal issue #139512.

@sunyab
Copy link
Contributor

sunyab commented Dec 3, 2016

This was addressed with dae3455 and 5ecad40.

@meshula
Copy link
Member Author

meshula commented Dec 3, 2016

Cheers :)

@meshula meshula closed this as completed Dec 3, 2016
@Felix-Kit Felix-Kit mentioned this issue Feb 9, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@meshula @sunyab @jtran56